Patch 1 #2
Open
Patch 1 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. removed previously required field 'description', and 'rights_holder', 2. added required field for 'visibility' and either 'rights' or 'license'. 3. doesn't validate against date field 4. validate accepted value (URI) for both rights and license
Accepted Supporting Information and readme folder, excluded special character check for folder names (case insensitive), restricted special characters in identifiers, check for readme file in root or readme folder.
Upload the file with exact same filename later.
Accepted 'Supporting Information' and 'readme' folder, excluded special character check for folder names (case insensitive), restricted special characters in identifiers, check for readme file in root or readme folder.
Removed case sensitivity for 'identifier', refined special character validation for 'identifier' and folder names, and allowed spaces in folder names.
- Ensured special character validation only applies to actual folders before checking if folder is extra. - Added validation for the 'visibility' field to accept only 'true' or 'false' (case-insensitive). - Enforced that item_metadata.csv must contain either rights or license, validated against controlled values.
Update README.md according to updated sip-validator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited sip-validator to better align with DLP metadata requirements and Virginia Tech Digital Library Submission Information Package by updating required fields, adding validation for specific fields, and improving folder checks. The script now flags missing folders, validates special characters in folder names and identifiers, and ensures compliance with controlled values for rights or license and visibility.
What does this Pull Request do? (:star:)
This aims to improve the sip-validator by ensuring better compliance with metadata and SIP requirements. It resolves issues with incorrect folder validation, adds robust checks for required fields, and validates controlled values for rights, license, and visibility. It also flags missing folders, invalid special characters, and ensures metadata conforms to expected standards.
What's the changes? (:star:)
A in-depth description of the changes made by this PR. Technical details and possible side effects.
identifier,title,rights- only for item_metadata.csv, andvisibility).rightsorlicense, andvisibilityfields.identifierand folder names.datefield validation.How should this be tested?
Interested parties
Tag (@ mention) interested parties
(:star:) Required fields